PoS Validator Management

[AeonSw4n]

No description provided.

[AeonSw4n]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

Current dependencies on/for this PR:

• feature/pos-networking-and-syncing
  • PR PoS Validator Constants and Network Changes #876
    • PR PoS Validator Connect/Disconnect Flow  #768
      • PR PoS RemoteNode and RemoteNodeId #857
        • PR PoS Remote Node Indexer and Manager #879
          • PR PoS HandshakeController #860
            • PR PoS ConnectionController #861
        • PR PoS RemoteNodeIndexer #858
          • PR PoS RemoteNodeIndexerManager #859
      • PR PoS Validator Handshake #792
        • PR PoS Validator Management #793 👈

This stack of pull requests is managed by Graphite.

[tholonious]

All of the changes in this file are related to peer management for the validator set, and related to maintaining connections between nodes. The changes introduced by this PR are not directly related to maintaining state of the blockchain or state of the Fast-HotStuff event loop based on internal events (block proposal, vote, timeout) and external messages from peers (blocks, vote, timeouts)

IMO, we should keep this ConsensusController scoped to just maintaining state blockchain and state of the Fast-HotStuff event loop based on the above events and and messages.

IMO, it's clearer to move all of the peer management, validator handshake, and validator connection maintenance from this file to a separate file, ex: pos_validator_management.go that's scoped to just these three items. The loop to re-sync the validator set may live in server or in the new file. IMO, this the ConsensusController is not the best place to house it though.