Create UtxoView Helper Function to Simulate Next Epoch Entry #850
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2023
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
tholonious
commented
Dec 5, 2023
| func (bav *UtxoView) computeNextEpochEntry(currentEpochNumber uint64, currentEpochFinalBlockHeight uint64, currentEpochFinalView uint64, nextEpochBlockTimestampNanoSecs uint64) (*EpochEntry, error) { | ||
| // Retrieve the SnapshotGlobalParamsEntry to determine the next epoch's final block height. We use the | ||
| // snapshot global params here because the next epoch begin immediately, and its length is used in the PoS | ||
| // consensus. The validator set for the next epoch needs to be in agreement on the length of the epoch | ||
| // before the epoch begins. | ||
| snapshotGlobalParamsEntry, err := bav.GetCurrentSnapshotGlobalParamsEntry() | ||
| snapshotAtEpochNumber, err := bav.ComputeSnapshotEpochNumberForEpoch(currentEpochNumber) |
There was a problem hiding this comment.
We shouldn't assume that the currentEpochNumber value passed in is the utxoView's current epoch value
This was referenced Dec 5, 2023
lazynina
approved these changes
Dec 5, 2023
This was referenced Dec 5, 2023
tholonious
force-pushed
the
Sign_Random_Seed_Hash_in_PoS_Block_Proposal
branch
from
bb5fe04 to
e1d4829
Compare
Base automatically changed from
Sign_Random_Seed_Hash_in_PoS_Block_Proposal
to
feature/pos-networking-and-syncing
December 5, 2023 01:38
tholonious
force-pushed
the
Create_UtxoView_Helper_Function_to_Simulate_Next_Epoch_Entry
branch
from
5065221 to
a81d785
Compare
tholonious
deleted the
Create_UtxoView_Helper_Function_to_Simulate_Next_Epoch_Entry
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.