feature/pos-syncing-and-steady-state

[tholonious]

No description provided.

[diamondhands0]

In block_view.go there is a line effectiveFeeU256 := failingTransactionRate.Mul(failingTransactionRate, failingTransactionFee). Change it to effectiveFeeU256 := uint256.NewInt().Mul(failingTransactionRate, failingTransactionFee)

Always use NewInt when assigning to a new variable.

[diamondhands0]

Also in block_view.go:3928, I think you could overflow after the multiplication.

	effectiveFeeU256 := failingTransactionRate.Mul(failingTransactionRate, failingTransactionFee)
        // Add a check for overflow here. 
	effectiveFeeU256.Div(effectiveFeeU256, basisPointsAsUint256)

I think for multiplication, you check that the resulting value is bigger than each of the two multiplied values.

[diamondhands0]

Also in block_view.go:_connectFailingTransaction on line 3938, I think you're comparing a raw txn fee to a fee rate:

	if effectiveFee < gp.MinimumNetworkFeeNanosPerKB {
		effectiveFee = gp.MinimumNetworkFeeNanosPerKB
	}

To fix this, I think you need to multiply by 1k and divide by the size of the txn, and maybe add one in the comparison to cover truncation. Then you need to set effectiveFee = minimum * 1000 / txnSize.

Also add some tests to check this.