PoS ConnectionController Routines #911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 11, 2024
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
AeonSw4n
force-pushed
the
p/pos-connection-controller
branch
from
104c3ec to
18af87c
Compare
AeonSw4n
force-pushed
the
p/pos-connection-controller-routines
branch
7 times, most recently
from
9c005be to
bcdaf49
Compare
|
Important edge-case: Make sure to check for public key duplication while refreshing validators. It's possible that two or more remote nodes (de-indexed to be non-validators after handshake) have the same inactive validator public key, that's undetected until the the public key becomes active and we refresh validators. Disconnect the duplicate validator then. |
AeonSw4n
force-pushed
the
p/pos-connection-controller
branch
from
a4d716c to
92e1d23
Compare
AeonSw4n
force-pushed
the
p/pos-connection-controller-routines
branch
4 times, most recently
from
1854db3 to
18fcca7
Compare
AeonSw4n
force-pushed
the
p/pos-connection-controller
branch
from
3f72440 to
62c9cbb
Compare
AeonSw4n
force-pushed
the
p/pos-connection-controller-routines
branch
from
f1fe09a to
143dcfc
Compare
This reverts commit 104c3ec. Some cleanup and documenting Cleanup; document more nit ConnectIps test Better connectIps test; simplify ConnectionController tests refactor
Base automatically changed from
p/pos-connection-controller
to
feature/pos-networking-and-syncing
January 24, 2024 16:48
AeonSw4n
force-pushed
the
p/pos-connection-controller-routines
branch
from
27e839d to
63b1bcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.