draft atomic txns pr #932
Closed
draft atomic txns pr #932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
lazynina
force-pushed
the
draft-atomic-txns
branch
4 times, most recently
from
2dd1b9b to
9abb579
Compare
lazynina
force-pushed
the
draft-atomic-txns
branch
from
9abb579 to
ca353cf
Compare
| return 0, 0, nil, errors.Wrapf(err, "_connectAtomicTxns: Problem serializing txn: ") | ||
| } | ||
| // Connect the transaction and update the view. | ||
| innerUtxoOps, innerTotalInput, innerTotalOutput, innerFees, err := viewCopy.ConnectTransaction( |
There was a problem hiding this comment.
Hmm... it doesn't make a practical difference but I feel a little more comfortable calling the _connectTransaction version here since it's kindof an internal connection.
| var utxoOps []*UtxoOperation | ||
| // Create copy of view. We apply all transactions to the copy first, and then | ||
| // if successful, apply to the real view. | ||
| viewCopy, err := bav.CopyUtxoView() |
There was a problem hiding this comment.
I don't think you need to do this viewCopy thing. Why not just error if you fail on one of the txns? It's already understood that the view will be compromised if an error happens in the middle of connecting a txn right?
| } | ||
|
|
||
| // TODO: more validations | ||
| func (bav *UtxoView) _verifyAtomicTxn(txn *MsgDeSoTxn) error { |
There was a problem hiding this comment.
Seems it's not called in the _connect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.