4larin/component routing #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enjoy2Live
requested changes
Jan 31, 2022
| }, | ||
| ]} | ||
| > | ||
| <Input /> |
There was a problem hiding this comment.
Why everything here is an input field?
there are different fields we use and some of them are way more complicated, for example but no limited to: description uses markdown input field
Comment on lines
+61
to
+73
| <Upload.Dragger | ||
| name="heroImage" | ||
| action={`${apiUrl}/media/upload`} | ||
| listType="picture" | ||
| maxCount={5} | ||
| multiple | ||
| > | ||
| <ImageField | ||
| value="" | ||
| title="" | ||
| width={200} | ||
| /> | ||
| </Upload.Dragger> |
There was a problem hiding this comment.
We only have one heroImage and here it's possible for a user to put multiple!
Comment on lines
+102
to
+106
| {/* <ShowButton | ||
| hideText | ||
| size="small" | ||
| recordItemId={record.id} | ||
| /> | ||
| /> */} |
There was a problem hiding this comment.
I did hide this as it's not going to be used for now.
Comment on lines
+13
to
+15
| { label: "Slug", name: "slug", required: true }, | ||
| { label: "CatchPhrase", name: "catchPhrase", required: true }, | ||
| { label: "Title", name: "title", required: true }, |
There was a problem hiding this comment.
The second key of these three array objects is "name" but the rest is "title". we have to be consistent with those names so either pick "title" or "name"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.