Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Profile): #1930 update profile schema and tested #222

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anne-creator
Copy link

add Location, Role, Headline, Website as text under Profile Schema, and tested.

@anne-creator anne-creator added the enhancement New feature or request label Sep 8, 2024
Copy link

github-actions bot commented Sep 8, 2024

Code Coverage

Package Line Rate Branch Rate Health
src 65% 50%
src.api.applicant.content-types.applicant 25% 0%
src.api.applicant.controllers 100% 100%
src.api.applicant.routes 100% 100%
src.api.applicant.services 100% 100%
src.api.category.controllers 100% 100%
src.api.category.routes 100% 100%
src.api.category.services 100% 100%
src.api.comment.content-types.comment 100% 100%
src.api.comment.controllers 100% 100%
src.api.comment.routes 100% 100%
src.api.comment.services 100% 100%
src.api.dl-tal-community.controllers 100% 100%
src.api.dl-tal-community.routes 100% 100%
src.api.dl-tal-community.services 100% 100%
src.api.event.content-types.event 88% 100%
src.api.event.controllers 100% 100%
src.api.event.routes 100% 100%
src.api.event.services 100% 100%
src.api.github-repo.controllers 20% 100%
src.api.github-repo.routes 100% 100%
src.api.github-repo.services 15% 0%
src.api.google-meet.content-types.google-meet 33% 100%
src.api.google-meet.controllers 100% 100%
src.api.google-meet.routes 100% 100%
src.api.google-meet.services 100% 100%
src.api.idea-card.content-types.idea-card 100% 100%
src.api.idea-card.controllers 100% 100%
src.api.idea-card.routes 100% 100%
src.api.idea-card.services 100% 100%
src.api.interest.controllers 100% 100%
src.api.interest.routes 100% 100%
src.api.interest.services 100% 100%
src.api.like.controllers 100% 100%
src.api.like.routes 100% 100%
src.api.like.services 100% 100%
src.api.newsletter.controllers 100% 100%
src.api.newsletter.routes 100% 100%
src.api.newsletter.services 100% 100%
src.api.notification.controllers 100% 100%
src.api.notification.policies 100% 88%
src.api.notification.routes 100% 100%
src.api.notification.services 100% 100%
src.api.opportunity.controllers 100% 100%
src.api.opportunity.routes 100% 100%
src.api.opportunity.services 100% 100%
src.api.profile.content-types.profile 12% 0%
src.api.profile.controllers 100% 100%
src.api.profile.routes 100% 100%
src.api.profile.services 100% 100%
src.api.project.controllers 100% 100%
src.api.project.routes 100% 100%
src.api.project.services 100% 100%
src.api.save-idea.controllers 100% 100%
src.api.save-idea.routes 100% 100%
src.api.save-idea.services 100% 100%
src.api.sendmail.controllers 100% 100%
src.api.sendmail.routes 100% 100%
src.api.sendmail.services 67% 100%
src.api.subscription.controllers 100% 100%
src.api.subscription.routes 100% 100%
src.api.subscription.services 100% 100%
src.api.team-membership.controllers 100% 100%
src.api.team-membership.routes 100% 100%
src.api.team-membership.services 100% 100%
src.api.user-recommendations.controllers 10% 0%
src.api.user-recommendations.routes 100% 100%
src.extensions.users-permissions 100% 100%
src.extensions.users-permissions.controllers 75% 100%
src.extensions.users-permissions.routes.content-api 100% 100%
src.extensions.users-permissions.server.bootstrap 100% 62%
src.extensions.users-permissions.server.middlewares 70% 59%
src.extensions.users-permissions.server.services 11% 0%
src.migrators 89% 50%
Summary 57% (293 / 516) 33% (42 / 129)

@chungthuang chungthuang requested a review from a team September 8, 2024 19:56
@@ -44,6 +44,18 @@
"config": {
"provider": "azure-storage"
}
},
"location": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can give it a more specific name? Is location a zip code, country, time zone or something else?

"location": {
"type": "string"
},
"role": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the user's role (developer, designer, etc) inside Dev Launchers?

Copy link

@judeamos judeamos Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chungthuang, this will describe the role they want to do or are doing, in or out of dev launchers - a designer, developer etc..
Basically how they want to be viewed as. I've attached a screenshot of the UI where i will be integrated into

image

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this looks like we have category of roles (developer, UX/UI, other) which is similar to roleCategory in opportunity collection. I think this is a good use case for components, so we share the same role category across our collections.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like 64f2042.

"headline": {
"type": "string"
},
"website": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What kind of website will this be? Someone's portfolio, LinkedIn, etc? Maybe this can be a list?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be a portfolio website. We can add a separate linkedin later.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can call this field portfolioWebsite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants