feat: Create a reusable component for role category and migrate opportunity to use it #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiagopazhs
reviewed
Sep 25, 2024
| ] | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Hey @chungthuang I didn't understood very well why use it as a Enum inside a Component instead of use it just as a enum.
Could you explain ?
Follow bellow 2 different attributes with different behaviors, roleType and roleCategory.
There was a problem hiding this comment.
roleType might not be the best name, but it means the name of the role. It's defined in https://github.com/dev-launchers/strapiv4/pull/228/files#diff-8385a8efd2cb2543e792c4e88ce7a586cf150d72489cfe80e3ba2a3b03c4a6a9R59-R73.
For example, both Front-End Developer and Back-End Developer will fall under Developer roleCategory.
There was a problem hiding this comment.
Hmm maybe it is something like a subcategory ?
Let me know if it is correct.
We can create a model roleCategory that has the attribute category.
But to make it practical we can use it as a component ?
chungthuang
force-pushed
the
cthuang/reusable-role-category
branch
from
ad03b8e
to
ad83408
Compare
chungthuang
force-pushed
the
cthuang/reusable-role-category
branch
from
ad83408
to
a395148
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #227