Fix the read detection to work correctly with MongoDB Atlas

dev4good · Nov 14, 2020 · d7f472a · d7f472a
1 parent edf432a
commit d7f472a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/server/booterror.js b/lib/server/booterror.js
@@ -26,7 +26,7 @@ function bootError(env, ctx) {
       } else {
         message = JSON.stringify(_.pick(obj.err, Object.getOwnPropertyNames(obj.err)));
       }
-      return '<dt>' + obj.desc + '</dt><dd>' + message.replace(/\\n/g, '<br/>') + '</dd>';
+      return '<dt><b>' + obj.desc + '</b></dt><dd>' + message.replace(/\\n/g, '<br/>') + '</dd>';
     }).join(' ');
 
     res.render('error.html', {

diff --git a/lib/server/bootevent.js b/lib/server/bootevent.js
@@ -133,7 +133,7 @@ function boot (env, language) {
           if (err) {
             console.info('ERROR CONNECTING TO MONGO', err);
             ctx.bootErrors = ctx.bootErrors || [ ];
-            ctx.bootErrors.push({'desc': 'Unable to connect to Mongo', err: err});
+            ctx.bootErrors.push({'desc': 'Unable to connect to Mongo', err: err.message});
           }
           console.log('Mongo Storage system ready');
           ctx.store = store;
@@ -143,7 +143,7 @@ function boot (env, language) {
     } catch (err) {
       console.info('ERROR CONNECTING TO MONGO', err);
       ctx.bootErrors = ctx.bootErrors || [ ];
-      ctx.bootErrors.push({'desc': 'Unable to connect to Mongo', err: err});
+      ctx.bootErrors.push({'desc': 'Unable to connect to Mongo', err: err.message});
       next();
     }
   }

diff --git a/lib/storage/mongo-storage.js b/lib/storage/mongo-storage.js
@@ -47,7 +47,7 @@ function init (env, cb, forceNewConnection) {
             mongo.db.command({ connectionStatus: 1 }).then(
               result => {
                 const roles = result.authInfo.authenticatedUserRoles;
-                if (roles.lenght > 0 && roles[0].role == 'read') {
+                if (roles.length > 0 && roles[0].role == 'readAnyDatabase') {
                   console.error('Mongo user is read only');
                   cb(new Error('MongoDB connection is in read only mode! Go back to MongoDB configuration and check your database user has read and write access.'), null);
                 }