Skip to content

Commit

Permalink
gh-release requires git as part of the install process (#570)
Browse files Browse the repository at this point in the history
  • Loading branch information
danielbraun89 authored Jan 6, 2024
1 parent 84379a3 commit 9a1d24b
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/gh-release/devcontainer-feature.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "gh-release",
"version": "1.0.24",
"version": "1.0.25",
"name": "Github Release",
"documentationURL": "http://github.com/devcontainers-contrib/features/tree/main/src/gh-release",
"description": "Github Release feature will download, extract and add to path a release binary from a given repo",
Expand Down
2 changes: 1 addition & 1 deletion src/gh-release/install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ set -e
# `ensure_nanolayer` is a bash function that will find any existing nanolayer installations,
# and if missing - will download a temporary copy that automatically get deleted at the end
# of the script
ensure_nanolayer nanolayer_location "v0.5.5"
ensure_nanolayer nanolayer_location "v0.5.6"



Expand Down
10 changes: 10 additions & 0 deletions test/gh-release/scenarios.json
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,15 @@
"additionalFlags": "--no-filter-assets-by-platform"
}
}
},
"test_no_git": {
"image": "ubuntu",
"features": {
"gh-release": {
"version": "latest",
"repo": "Azure/aztfexport",
"binaryNames": "aztfexport"
}
}
}
}
9 changes: 9 additions & 0 deletions test/gh-release/test_no_git.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
#!/bin/bash -i

set -e

source dev-container-features-test-lib

check "aztfexport --version" aztfexport --version

reportResults

1 comment on commit 9a1d24b

@Troyblants
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#

Please sign in to comment.