Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix bitwarden-cli by selected oss binary #636

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

osechet
Copy link

@osechet osechet commented Aug 20, 2024

This PR fixes the bitwarden-cli feature. The issue was due to the fact bitwarden cli is now released in 2 "flavors": bw and bw-oss.

The fix downloads the "oss" version.

Additionally, the PR updates the github actions versions to avoid warning about nodejs.

The bitwarden-cli feature tests pass.

@brizdotdev
Copy link

Why the "oss" version instead of the regular one? What are the differences between the 2?

@evilhamsterman
Copy link

This project is not associated with the devcontainer project and appears to have been abandoned #628 . The official project has removed all devcontainer-contrib features from their listing. devcontainers/devcontainers.github.io#451. There is a fork that is being worked on to update and maintain the features https://github.com/devcontainers-extra/features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants