solution to cli issue TypeError: Cannot read properties of undefined …

…(reading 'fsPath') #895
devcontainers · Oct 28, 2024 · 925a1eb · 925a1eb
1 parent 9ba1fda
commit 925a1eb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/spec-configuration/lockfile.ts b/src/spec-configuration/lockfile.ts
@@ -67,7 +67,7 @@ export async function writeLockfile(params: ContainerFeatureInternalParams, conf
 	return;
 }
 
-export async function readLockfile(config: DevContainerConfig): Promise<{ lockfile?: Lockfile; initLockfile?: boolean }> {
+export async function readLockfile(config: DevContainerConfig | string): Promise<{ lockfile?: Lockfile; initLockfile?: boolean }> {
 	try {
 		const content = await readLocalFile(getLockfilePath(config));
 		// If empty file, use as marker to initialize lockfile when build completes.

diff --git a/src/spec-node/featuresCLI/resolveDependencies.ts b/src/spec-node/featuresCLI/resolveDependencies.ts
@@ -84,7 +84,9 @@ async function featuresResolveDependencies({
 		env: process.env,
 	};
 
-	const { lockfile } = await readLockfile(config);
+	let configObj: DevContainerConfig | string = config.hasOwnProperty('configFilePath') && config.configFilePath ? config : configPath;
+
+	const { lockfile } = await readLockfile(configObj);
 	const processFeature = async (_userFeature: DevContainerFeature) => {
 		return await processFeatureIdentifier(params, configPath, workspaceFolder, _userFeature, lockfile);
 	};