Handle missing entry in /etc/passwd gracefully

devcontainers · Aug 25, 2023 · c960d97 · c960d97
1 parent 199a4f1
commit c960d97
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/src/spec-common/commonUtils.ts b/src/spec-common/commonUtils.ts
@@ -588,5 +588,5 @@ export function getEntPasswdShellCommand(userNameOrId: string) {
 	const escapedForRexExp = escapeRegExCharacters(userNameOrId)
 		.replaceAll('\'', '\\\'');
 	// Leading space makes sure we don't concatenate to arithmetic expansion (https://tldp.org/LDP/abs/html/dblparens.html).
-	return ` (command -v getent >/dev/null 2>&1 && getent passwd '${escapedForShell}' || grep -E '^${escapedForRexExp}|^[^:]*:[^:]*:${escapedForRexExp}:' /etc/passwd)`;
+	return ` (command -v getent >/dev/null 2>&1 && getent passwd '${escapedForShell}' || grep -E '^${escapedForRexExp}|^[^:]*:[^:]*:${escapedForRexExp}:' /etc/passwd || true)`;
 }
diff --git a/src/spec-common/injectHeadless.ts b/src/spec-common/injectHeadless.ts
@@ -287,6 +287,9 @@ async function getUserShell(containerEnv: NodeJS.ProcessEnv, passwdUser: PasswdU
 
 export async function getUserFromPasswdDB(shellServer: ShellServer, userNameOrId: string) {
 	const { stdout } = await shellServer.exec(getEntPasswdShellCommand(userNameOrId), { logOutput: false });
+	if (!stdout.trim()) {
+		return undefined;
+	}
 	return parseUserInPasswdDB(stdout);
 }
 

diff --git a/src/test/getEntPasswd.test.ts b/src/test/getEntPasswd.test.ts
@@ -60,6 +60,9 @@ describe('getEntPasswdShellCommand', function () {
 			assert.strictEqual(userById.name, userName);
 			assert.strictEqual(userById.home, '/home/foo');
 
+			const nonexistentUser = await getUserFromPasswdDB(shellServer, '123456');
+			assert.strictEqual(undefined, nonexistentUser);
+
 			await shellExec(`docker rm -f ${containerId}`);
 		});
 	});