Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idea for refactor of workflows #66

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jcbhmr
Copy link
Contributor

@jcbhmr jcbhmr commented Aug 18, 2023

no, i dont expect this to be merged as-is. this pr is intended to be EDITED and IMPROVED to align with whatever the official template is willing to accept

this pr would:

  • make it so that there's a commented out on: push: main block that can be enabled by the user if they prefer
  • explicitly login to docker and use the cli
  • use .yml instead of .yaml (.yml is 2x more popular on github search) (somewhat opinionated changed)
  • longer names for workflow files (opinionated changed)
  • update feature readmes in a separate workflow file (separation of concerns)
  • CONTINUOUSLY update feature readmes via automatic commits to prs and main on changes (opinionated change)
  • use a dynamic relevant-features matrix to test only changed features on prs and pushes
  • still allow workflow_dispatch manual testing of ALL features

expl on why i used docker+devcontainer instead of the official action: its more clear what is happening. not really anything else, the devcontainer/action is a black box that can do like 4 different things if you prod it the wrong way 🤣 also its clear here where and when we are authing with docker instead of magically inside the devcontainers/action action. kinda addresses confusion of devcontainers/action#143

I EXPECT SOME OF THESE THINGS TO BE REQUESTED TO BE CHANGED that's ok 😊 this is just some ideas that i hope some of which can be merged after discussion.

sidenote: idk if you want me to split this into multiple isolated prs or what 🤷‍♀️ idk on ettiquite here for larger-ish changes like this. should i open an issue to discuss this instead? 😵

ref devcontainers/action#197

ideas from https://github.com/devcontainers-community/npm-features and https://github.com/devcontainers-community/features-starter

@jcbhmr jcbhmr marked this pull request as ready for review August 20, 2023 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant