[python] - solution to features issue #870 - unable to open codespace in jupyterlab #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pen codespace in jupyterlab
eitsupi
reviewed
Oct 21, 2024
| @@ -67,7 +67,7 @@ | |||
| "PYTHON_PATH": "/usr/local/python/current", | |||
| "PIPX_HOME": "/usr/local/py-utils", | |||
| "PIPX_BIN_DIR": "/usr/local/py-utils/bin", | |||
| "PATH": "/usr/local/python/current/bin:/usr/local/py-utils/bin:${PATH}" | |||
| "PATH": "/usr/local/python/current/bin:/usr/local/py-utils/bin:/usr/local/share/nvm/current/bin:/usr/local/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/home/vscode/.local/bin:${PATH}" | |||
There was a problem hiding this comment.
The user name vscode is hard coded. Is that ideal?
There was a problem hiding this comment.
+1, This solution would prevent the feature from working for people who have specified the containerUser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #870
Feature Name
Description
codespacewasn't able to open injupyterlabwithpythonfeature instead of the bulkyuniversalimage as suggested in docsChangelog
containerEnv['PATH']indevcontainer-feature.jsoninpythonfeatureChecklist