-
Notifications
You must be signed in to change notification settings - Fork 377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid unexpected shell expansion #645
Avoid unexpected shell expansion #645
Conversation
@microsoft-github-policy-service agree |
570dc21
to
b5fba92
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for taking the time to contribute this PR.
Left a minor comment.
Looks like the tests are failing due to ^ disk space issues , see https://github.com/devcontainers/features/actions/runs/5813161318/job/15762628752?pr=645#step:4:3293 @shikanime can you help remove the "install_node_on_universal_image" scenario? features/test/node/scenarios.json Lines 40 to 48 in 5128a41
The universal image is ~ 12.5 GB, we shouldn't be using such a big image which will result in slow (local) test runs. Also, it would help fix the disk space issue in the runners. I'll create an issue for myself to re-add a (slim) test scenario as a replacement. |
Opened #646 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks!
Some variables may contain symbols such as wildcards, which can be expanded by other shell interpreters such as ZSH.
Fix: #569