Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unexpected shell expansion #645

Merged

Conversation

shikanime
Copy link
Contributor

Some variables may contain symbols such as wildcards, which can be expanded by other shell interpreters such as ZSH.

Fix: #569

@shikanime
Copy link
Contributor Author

@microsoft-github-policy-service agree

@shikanime shikanime marked this pull request as ready for review August 9, 2023 10:26
@shikanime shikanime requested a review from a team as a code owner August 9, 2023 10:26
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for taking the time to contribute this PR.
Left a minor comment.

src/node/install.sh Show resolved Hide resolved
@samruddhikhandale
Copy link
Member

ERROR: failed to solve: failed to register layer: ApplyLayer exit status 1 stdout: stderr: write /usr/local/bin/git: no space left on device

Looks like the tests are failing due to ^ disk space issues , see https://github.com/devcontainers/features/actions/runs/5813161318/job/15762628752?pr=645#step:4:3293

@shikanime can you help remove the "install_node_on_universal_image" scenario?

"install_node_on_universal_image": {
"image": "mcr.microsoft.com/devcontainers/universal",
"remoteUser": "codespace",
"features": {
"node": {
"version": "19.1.0"
}
}
},

The universal image is ~ 12.5 GB, we shouldn't be using such a big image which will result in slow (local) test runs. Also, it would help fix the disk space issue in the runners.

I'll create an issue for myself to re-add a (slim) test scenario as a replacement.

@samruddhikhandale
Copy link
Member

Opened #646

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@samruddhikhandale samruddhikhandale merged commit 9e75db9 into devcontainers:main Aug 9, 2023
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node Feature fails when zsh is configured as default shell on Ubuntu dev container
2 participants