[docker-in-docker] Reverts the retry logic #659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samruddhikhandale
changed the title
joshspicer
reviewed
Aug 18, 2023
joshspicer
reviewed
Aug 18, 2023
samruddhikhandale
changed the title
samruddhikhandale
changed the title
joshspicer
approved these changes
Aug 18, 2023
samruddhikhandale
deleted the
samruddhikhandale/docker-in-docker-add-sleep
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #634
Reverts #637
With addition of the retry logic, we have seen issues where docker starts but stops in between lifecycle hooks (esp
onCreateCommand). See #634 (comment)Reverting the retry logic as it seems to cause other issues, will follow-up with another issue to fix this and
sed: couldn't flush stdout: Device or resourceerrorsEven I was able to reproduce the issue, (repro https://github.com/TRYON-Technology/Docker-in-Docker-Issue) it happens quite too often. My hypothesis is that the retry logic checks for docker status too early and triggers for a retry which brings the docker in an inconsistent state. (Docker needs at least few mili-seconds to start). Hence, this PR aims to add sleep in between docker start and retry logic.Note: See https://github.com/samruddhikhandale/Docker-in-Docker-Issue, with these PR changes I was able to create codespaces successfully 10 times in a row.