Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[universal] - Issue universal config change for non-root default codespace user and installing google chrome browser reuse sandbox to run puppeteer cli in universal image" #1315

Conversation

Kaniska244
Copy link
Contributor

@Kaniska244 Kaniska244 commented Feb 24, 2025

Descripotion: Reverts #1287 partially. Would still need to keep the fix done for UID & GID issue (https://github.com/devcontainers/internal/issues/247) to ensure oryx-install-dotnet-2.1 test step is successful. Also changes done in the image size check test as suggested during review of #1287 . Need to keep that as well to ensure size check test doesn’t fail unnecessarily, checking the updated image which will not be released.

Changelog:

  • Change done in ./src/universal/test-project/test.sh to add ownership for codespace user to ensure oryx-install-dotnet-2.1 test step is successful. Also removed run-puppeteer test step as discussed.
  • Changes done in ./.github/actions/smoke-test/check-image-size.sh to change the image size check logic so that the correct image is checked.
  • Changes done in ./.github/actions/smoke-test/build.sh to change the image size check logic so that the correct image is checked.
  • Changes done in ./.github/actions/smoke-test/test.sh to change the image size check logic so that the correct image is checked.

@Kaniska244 Kaniska244 requested a review from a team as a code owner February 24, 2025 17:01
…all-dotnet-2.1 resr step to succeed. Also change done in image size check part.
Copy link
Contributor

@ddoyle2017 ddoyle2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up our discussion with this!

For context: introducing Chrome for puppeteer to use during the test step is causing image size issues, so we're temporarily disabling the test + rolling back adding Chrome

@ddoyle2017 ddoyle2017 merged commit d135037 into devcontainers:main Feb 25, 2025
2 checks passed
@Kaniska244 Kaniska244 deleted the revert-1287-Issue_Universal_Config_change_codespace_user branch February 25, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants