Skip to content

Commit

Permalink
[node]-22-bookworm release changes (#252)
Browse files Browse the repository at this point in the history
* [node]-22-bookworm release changes

* changes as required in comments

* changes for tests failing
  • Loading branch information
gauravsaini04 authored May 13, 2024
1 parent cee7ba0 commit c0d3963
Show file tree
Hide file tree
Showing 9 changed files with 45 additions and 69 deletions.
7 changes: 5 additions & 2 deletions src/javascript-node-mongo/devcontainer-template.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "javascript-node-mongo",
"version": "3.1.0",
"version": "3.2.0",
"name": "Node.js & Mongo DB",
"description": "Develop applications in Node.js and Mongo DB. Includes Node.js, eslint, and yarn in a container linked to a Mongo DB.",
"documentationURL": "https://github.com/devcontainers/templates/tree/main/src/javascript-node-mongo",
Expand All @@ -11,12 +11,15 @@
"type": "string",
"description": "Node.js version (use -bullseye variants on local arm64/Apple Silicon):",
"proposals": [
"22-bookworm",
"22-bullseye",
"20-bookworm",
"20-bullseye",
"18-bullseye",
"20-buster",
"18-buster"
],
"default": "20-bullseye"
"default": "22-bookworm"
}
},
"platforms": [
Expand Down
7 changes: 5 additions & 2 deletions src/javascript-node-postgres/devcontainer-template.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "javascript-node-postgres",
"version": "3.1.0",
"version": "3.2.0",
"name": "Node.js & PostgreSQL",
"description": "Develop applications in Node.js and PostgreSQL. Includes Node.js, eslint, and yarn in a container linked to a Postgres DB container",
"documentationURL": "https://github.com/devcontainers/templates/tree/main/src/javascript-node-postgres",
Expand All @@ -11,14 +11,17 @@
"type": "string",
"description": "Node.js version (use -bookworm, -bullseye variants on local arm64/Apple Silicon):",
"proposals": [
"22-bookworm",
"22-bullseye",
"20-bookworm",
"20-bullseye",
"18-bookworm",
"20-bullseye",
"18-bullseye",
"20-buster",
"18-buster"
],
"default": "20-bullseye"
"default": "22-bookworm"
}
},
"platforms": [
Expand Down
7 changes: 5 additions & 2 deletions src/javascript-node/devcontainer-template.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "javascript-node",
"version": "3.1.0",
"version": "3.2.0",
"name": "Node.js & JavaScript",
"description": "Develop Node.js based applications. Includes Node.js, eslint, nvm, and yarn.",
"documentationURL": "https://github.com/devcontainers/templates/tree/main/src/javascript-node",
Expand All @@ -11,14 +11,17 @@
"type": "string",
"description": "Node.js version (use -bookworm, -bullseye variants on local arm64/Apple Silicon):",
"proposals": [
"22-bookworm",
"22-bullseye",
"20-bookworm",
"20-bullseye",
"18-bookworm",
"20-bullseye",
"18-bullseye",
"20-buster",
"18-buster"
],
"default": "20-bullseye"
"default": "22-bookworm"
}
},
"platforms": [
Expand Down
21 changes: 0 additions & 21 deletions test/javascript-node-mongo/.eslintrc.json

This file was deleted.

10 changes: 10 additions & 0 deletions test/javascript-node-mongo/eslint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
module.exports = {
"rules": {
"no-console": 0,
"eqeqeq":"warn",
"no-cond-assign": 0,
"no-unused-vars": 1,
"no-extra-semi": "warn",
"semi": "warn"
}
};
21 changes: 0 additions & 21 deletions test/javascript-node-postgres/.eslintrc.json

This file was deleted.

10 changes: 10 additions & 0 deletions test/javascript-node-postgres/eslint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
module.exports = {
"rules": {
"no-console": 0,
"eqeqeq":"warn",
"no-cond-assign": 0,
"no-unused-vars": 1,
"no-extra-semi": "warn",
"semi": "warn"
}
};
21 changes: 0 additions & 21 deletions test/javascript-node/.eslintrc.json

This file was deleted.

10 changes: 10 additions & 0 deletions test/javascript-node/eslint.config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
module.exports = {
"rules": {
"no-console": 0,
"eqeqeq":"warn",
"no-cond-assign": 0,
"no-unused-vars": 1,
"no-extra-semi": "warn",
"semi": "warn"
}
};

0 comments on commit c0d3963

Please sign in to comment.