Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GO] - Add support for v1.23 #282

Merged
merged 5 commits into from
Sep 11, 2024
Merged

[GO] - Add support for v1.23 #282

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
371af47
[GO] - Add support for v1.23
gauravsaini04 Sep 4, 2024
4e13ce9
changes
gauravsaini04 Sep 5, 2024
628b5e0
Merge branch 'main' into go_v1.23_Add_support
gauravsaini04 Sep 7, 2024
33d006f
changes as wanted in pr review comments
gauravsaini04 Sep 10, 2024
3c85c41
Merge remote-tracking branch 'refs/remotes/origin/go_v1.23_Add_suppor…
gauravsaini04 Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/go-postgres/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Use and develop Go + Postgres applications. Includes appropriate runtime args, G

| Options Id | Description | Type | Default Value |
|-----|-----|-----|-----|
| imageVariant | Go version: | string | 1.22-bookworm |
gauravsaini04 marked this conversation as resolved.
Show resolved Hide resolved
gauravsaini04 marked this conversation as resolved.
Show resolved Hide resolved
| imageVariant | Go version: | string | 1.23-bookworm |
samruddhikhandale marked this conversation as resolved.
Show resolved Hide resolved

This template references an image that was [pre-built](https://containers.dev/implementors/reference/#prebuilding) to automatically include needed devcontainer.json metadata.

Expand Down
6 changes: 4 additions & 2 deletions src/go-postgres/devcontainer-template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "go-postgres",
"version": "4.0.2",
gauravsaini04 marked this conversation as resolved.
Show resolved Hide resolved
"version": "4.1.0",
"name": "Go & PostgreSQL",
"description": "Use and develop Go + Postgres applications. Includes appropriate runtime args, Go, common tools, extensions, and dependencies.",
"documentationURL": "https://github.com/devcontainers/templates/tree/main/src/go-postgres",
Expand All @@ -12,13 +12,15 @@
"description": "Go version:",
"proposals": [
"1-bookworm",
"1.23-bookworm",
samruddhikhandale marked this conversation as resolved.
Show resolved Hide resolved
"1.22-bookworm",
"1.21-bookworm",
"1-bullseye",
"1.23-bullseye",
"1.22-bullseye",
"1.21-bullseye"
],
"default": "1.22-bookworm"
gauravsaini04 marked this conversation as resolved.
Show resolved Hide resolved
"default": "1.23-bookworm"
}
},
"platforms": ["Go"],
Expand Down
2 changes: 1 addition & 1 deletion src/go/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ Develop Go based applications. Includes appropriate runtime args, Go, common too

| Options Id | Description | Type | Default Value |
|-----|-----|-----|-----|
| imageVariant | Go version: | string | 1.22-bookworm |
gauravsaini04 marked this conversation as resolved.
Show resolved Hide resolved
gauravsaini04 marked this conversation as resolved.
Show resolved Hide resolved
| imageVariant | Go version: | string | 1.23-bookworm |
gauravsaini04 marked this conversation as resolved.
Show resolved Hide resolved

This template references an image that was [pre-built](https://containers.dev/implementors/reference/#prebuilding) to automatically include needed devcontainer.json metadata.

Expand Down
6 changes: 4 additions & 2 deletions src/go/devcontainer-template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "go",
"version": "4.0.2",
gauravsaini04 marked this conversation as resolved.
Show resolved Hide resolved
gauravsaini04 marked this conversation as resolved.
Show resolved Hide resolved
"version": "4.1.0",
"name": "Go",
"description": "Develop Go based applications. Includes appropriate runtime args, Go, common tools, extensions, and dependencies.",
"documentationURL": "https://github.com/devcontainers/templates/tree/main/src/go",
Expand All @@ -12,13 +12,15 @@
"description": "Go version:",
"proposals": [
"1-bookworm",
"1.23-bookworm",
"1.22-bookworm",
"1.21-bookworm",
"1-bullseye",
"1.23-bullseye",
"1.22-bullseye",
"1.21-bullseye"
],
"default": "1.22-bookworm"
gauravsaini04 marked this conversation as resolved.
Show resolved Hide resolved
gauravsaini04 marked this conversation as resolved.
Show resolved Hide resolved
gauravsaini04 marked this conversation as resolved.
Show resolved Hide resolved
"default": "1.23-bookworm"
}
},
"platforms": ["Go"],
Expand Down
Loading