Pin version for all actions via SHA rather than floating tag #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
AObuchow
approved these changes
Jan 15, 2024
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: amisevsk, AObuchow The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Pin all actions used in workflows to the current latest bugfix release within their major version (e.g. v3 -> [hash for] v3.6.1) * Update all instances of docker/build-push-action to use latest v4 release instead of a mix of v3 and v4 * Remove mattermost message steps from release job, as mattermost is gone now. Signed-off-by: Angel Misevski <[email protected]>
amisevsk
force-pushed
the
pin-action-sha
branch
from
c88ff7c to
843e514
Compare
|
New changes are detected. LGTM label has been removed. |
|
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1220 +/- ##
==========================================
- Coverage 52.74% 52.70% -0.04%
==========================================
Files 84 84
Lines 7616 7616
==========================================
- Hits 4017 4014 -3
- Misses 3310 3312 +2
- Partials 289 290 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
docker/build-push-actionto use latest v4 release instead of a mix of v3 and v4Note: in most cases, there's a new major version for our actions (usually around switching from Node 16 -> 20. This PR does not switch major versions (except for some instances of
docker/build-push-action) to avoid any risk of breaking anything -- ideally these are the exact same versions of each action we're using right now.What issues does this PR fix or reference?
N/A
Is it tested? How?
N/A
PR Checklist
/test v8-devworkspace-operator-e2e, v8-che-happy-pathto trigger)v8-devworkspace-operator-e2e: DevWorkspace e2e testv8-che-happy-path: Happy path for verification integration with Che