Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cpu and memory limit for devworkspace-controller #1298

Merged
merged 2 commits into from
Aug 8, 2024

Conversation

dkwon17
Copy link
Collaborator

@dkwon17 dkwon17 commented Aug 8, 2024

What does this PR do?

This PR updates the CPU and memory limit of the devworkspace-controller container of the devworkspace-controller-manager-* pod from 1000m to 3000m and 1Gi to 3Gi respectively.

What issues does this PR fix or reference?

Part of https://issues.redhat.com/browse/CRW-6889
Fix #1299

Is it tested? How?

To test, run:

DWO_IMG_REPO=quay.io/<username>/<repo>
DWO_IMG_TAG=<tag>
export DWO_BUNDLE_IMG=${DWO_IMG_REPO}/devworkspace-operator-bundle:${DWO_IMG_TAG}
export DWO_INDEX_IMG=${DWO_IMG_REPO}/devworkspace-operator-index:${DWO_IMG_TAG}
export DOCKER=podman 
make generate_olm_bundle_yaml build_bundle_and_index register_catalogsource

And install the operator from OperatorHub.

Verify that the resulting devworkspace-controller-manager-* pod in the openshift-operators namespace has the new CPU and memory limit for the devworkspace-controller container.

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

@openshift-ci openshift-ci bot added the approved label Aug 8, 2024
@dkwon17 dkwon17 changed the title Update cpu limit Update cpu and memory limit for devworkspace-controller Aug 8, 2024
Copy link
Collaborator

@AObuchow AObuchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM & works as expected. Tested on OpenShift 4.16 using OLM.

spec:
(...)
  containers:
    - resources:
        limits:
          cpu: '3'
          memory: 3Gi
        requests:
          cpu: 250m
          memory: 100Mi

Note: 0.1 'CPU' = 100m, so 0.1 CPU X 30 = 3 CPU = 3000m

I wanted to try upgrading from DWO 0.29 -> 0.30-dev (using this PR) but there isn't an OLM upgrade path created until the upstream release procedure is done unfortunately.

@dkwon17 let me quickly create an issue for this PR so that we can track it more easily in the DWO 0.30 milestone

Copy link

openshift-ci bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AObuchow, dkwon17

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@AObuchow
Copy link
Collaborator

AObuchow commented Aug 8, 2024

@dkwon17 I've opened #1299 -- this PR is now good to merge :) Great work as always.

@dkwon17
Copy link
Collaborator Author

dkwon17 commented Aug 8, 2024

Thank you @AObuchow , merging

@dkwon17 dkwon17 merged commit 4b2fcda into devfile:main Aug 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase CPU & memory limits for the devworkspace-controller-manager deployment
2 participants