Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update images to ubi9 #1355

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Update images to ubi9 #1355

merged 1 commit into from
Dec 18, 2024

Conversation

dkwon17
Copy link
Collaborator

@dkwon17 dkwon17 commented Dec 3, 2024

What does this PR do?

Updates ubi8 images to ubi9 images for the conteroller and project-clone images.
Also updates the PVC cleanup pod image to ubi9/ubi-micro.

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-7863 & #1356

Is it tested? How?

Build the DWO image and the project clone image:

export DWO_IMG=quay.io/yourrepo/devworkspace-controller:prerelease
export PROJECT_CLONE_IMG=quay.io/yourrepo/project-clone:prerelease
# build and push project clone image
podman build -t "$PROJECT_CLONE_IMG" -f ./project-clone/Dockerfile .
podman push "$PROJECT_CLONE_IMG"
# build and push DevWorkspace Operator image
make docker
# deploy DevWorkspace Operator using these images
make install

Successfully follow section 3 from this doc: https://gist.github.com/amisevsk/1bdfa7b063e4c1a0cb420314a9c14ae6/66213a41c408554cdae23918796525c5db924d06#3-test-devworkspace-flow-in-the-new-version

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

Signed-off-by: dkwon17 <[email protected]>
# https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi8/go-toolset
FROM registry.access.redhat.com/ubi8/go-toolset:1.22.7-5 as builder
# https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi9/go-toolset
FROM registry.access.redhat.com/ubi9/go-toolset:1.22.7-1733160835 as builder

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: containerImage not pinned by hash
Remediation tip: pin your Docker image by updating registry.access.redhat.com/ubi9/go-toolset:1.22.7-1733160835 to registry.access.redhat.com/ubi9/go-toolset:1.22.7-1733160835@sha256:e8e961aebb9d3acedcabb898129e03e6516b99244eb64330e5ca599af9c7aa3d
Click Remediation section below for further remediation help
# https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi8-minimal
FROM registry.access.redhat.com/ubi8-minimal:8.10-1130
# https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi9-minimal
FROM registry.access.redhat.com/ubi9-minimal:9.5-1731593028

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: containerImage not pinned by hash
Remediation tip: pin your Docker image by updating registry.access.redhat.com/ubi9-minimal to registry.access.redhat.com/ubi9-minimal@sha256:b87097994ed62fbf1de70bc75debe8dacf3ea6e00dd577d74503ef66452c59d6
Click Remediation section below for further remediation help
# https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi8/go-toolset
FROM registry.access.redhat.com/ubi8/go-toolset:1.22.7-5 as builder
# https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi9/go-toolset
FROM registry.access.redhat.com/ubi9/go-toolset:1.22.7-1733160835 as builder

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: containerImage not pinned by hash
Remediation tip: pin your Docker image by updating registry.access.redhat.com/ubi9/go-toolset:1.22.7-1733160835 to registry.access.redhat.com/ubi9/go-toolset:1.22.7-1733160835@sha256:e8e961aebb9d3acedcabb898129e03e6516b99244eb64330e5ca599af9c7aa3d
Click Remediation section below for further remediation help
# https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi8-minimal
FROM registry.access.redhat.com/ubi8-minimal:8.10-1130
# https://access.redhat.com/containers/?tab=tags#/registry.access.redhat.com/ubi9-minimal
FROM registry.access.redhat.com/ubi9-minimal:9.5-1731593028

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 2: containerImage not pinned by hash
Remediation tip: pin your Docker image by updating registry.access.redhat.com/ubi9-minimal to registry.access.redhat.com/ubi9-minimal@sha256:b87097994ed62fbf1de70bc75debe8dacf3ea6e00dd577d74503ef66452c59d6
Click Remediation section below for further remediation help
Copy link
Collaborator

@AObuchow AObuchow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work David :)

I followed the testing instructions & verified everything works correctly (e.g. multiple workspace creation, the PVC cleanup job, etc).

Copy link

openshift-ci bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AObuchow, dkwon17, ibuziuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dkwon17 dkwon17 merged commit c47e453 into devfile:main Dec 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants