Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nc to project clone image #1363

Merged
merged 1 commit into from
Jan 3, 2025
Merged

Add nc to project clone image #1363

merged 1 commit into from
Jan 3, 2025

Conversation

dkwon17
Copy link
Collaborator

@dkwon17 dkwon17 commented Jan 3, 2025

What does this PR do?

Adds nc to the project clone image.

What issues does this PR fix or reference?

https://issues.redhat.com/browse/CRW-7860

Is it tested? How?

Build the project clone image:

export PROJECT_CLONE_IMG=quay.io/yourrepo/project-clone:prerelease
# build and push project clone image
podman build -t "$PROJECT_CLONE_IMG" -f ./project-clone/Dockerfile .

And verify that the nc tool runs exists, for example:

$ podman run -it --rm quay.io/dkwon17/project-clone:prerelease nc --version
Ncat: Version 7.92 ( https://nmap.org/ncat )

PR Checklist

  • E2E tests pass (when PR is ready, comment /test v8-devworkspace-operator-e2e, v8-che-happy-path to trigger)
    • v8-devworkspace-operator-e2e: DevWorkspace e2e test
    • v8-che-happy-path: Happy path for verification integration with Che

@dkwon17 dkwon17 requested a review from ibuziuk as a code owner January 3, 2025 06:24
@openshift-ci openshift-ci bot added the approved label Jan 3, 2025
Copy link

codecov bot commented Jan 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.53%. Comparing base (2303e13) to head (d46c70d).
Report is 18 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1363      +/-   ##
==========================================
- Coverage   52.56%   52.53%   -0.03%     
==========================================
  Files          85       85              
  Lines        7981     7989       +8     
==========================================
+ Hits         4195     4197       +2     
- Misses       3483     3490       +7     
+ Partials      303      302       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Jan 3, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkwon17, ibuziuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dkwon17 dkwon17 merged commit aa093f8 into devfile:main Jan 3, 2025
11 of 12 checks passed
@dkwon17 dkwon17 mentioned this pull request Jan 3, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants