Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create go 1.20 stack version #255

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Conversation

Jdubrick
Copy link
Contributor

@Jdubrick Jdubrick commented Dec 1, 2023

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?

This adds a new stack that supports Go version 1.20.x. This is done by adding version 2.3.0

Which issue(s) this PR fixes:

Link to github issue(s)

resolves devfile/api#1316

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jdubrick Overall the 2.3.0 looks good to me, I've tested the devfile locally with odo and works. I think we can create a 1.3.0 version too which will only support innerloop (similar to 1.2.0 but using go 1.20).

@thepetk thepetk self-requested a review December 4, 2023 15:19
Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Looks good to me label Dec 4, 2023
Copy link

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jdubrick, thepetk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jdubrick Jdubrick merged commit b804b7e into devfile:main Dec 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm Looks good to me
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a new version for go stack to support golang version 1.20
2 participants