TMS-914: Add new anchor-links block & functionalities #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vloy
reviewed
Mar 19, 2024
assets/scripts/anchor-links.js
Outdated
Comment on lines
1
to
3
| /* | ||
| * Copyright (c) 2023. Hion Digital | ||
| */ |
There was a problem hiding this comment.
Eikai turhaa, mutta väärä vuosi lipsahtanut
vloy
reviewed
Mar 19, 2024
Comment on lines
1
to
3
| .anchor-links { | ||
| &__list { | ||
| padding-left: 1rem; |
There was a problem hiding this comment.
Suggested change
| .anchor-links { | |
| &__list { | |
| padding-left: 1rem; | |
| .anchor-links { | |
| &__list { | |
| padding-left: $theme-spacing; |
?
vloy
reviewed
Mar 19, 2024
| style="background-image: url({image.sizes.large})"> | ||
| <div {?anchor}id="{anchor|attr}"{/anchor} | ||
| class="image-banner mt-4 mb-4 mt-8-tablet mb-8-tablet is-relative is-align-full has-background-cover" | ||
| style="background-image: url({image.sizes.large|attr})"> |
There was a problem hiding this comment.
Suggested change
| style="background-image: url({image.sizes.large|attr})"> | |
| style="background-image: url({image.sizes.large|url})"> |
There was a problem hiding this comment.
Palauttaahan se :) korjataan
vloy
reviewed
Mar 19, 2024
| <div class="image-gallery {align_class} gallery {column_class} js-image-gallery mt-8 mb-8 mt-11-desktop mb-11-desktop" | ||
| <div | ||
| {?anchor}id="{anchor|attr}"{/anchor} | ||
| class="image-gallery {align_class} gallery {column_class} js-image-gallery mt-8 mb-8 mt-11-desktop mb-11-desktop" |
There was a problem hiding this comment.
Suggested change
| class="image-gallery {align_class} gallery {column_class} js-image-gallery mt-8 mb-8 mt-11-desktop mb-11-desktop" | |
| class="image-gallery {align_class|attr} gallery {column_class|attr} js-image-gallery mt-8 mb-8 mt-11-desktop mb-11-desktop" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Severa-ID: 2108
Severa-kuvaus: TMS-914 8 - Ankkurilinkit
Task: https://hiondigital.atlassian.net/browse/TMS-914
Description
Types of changes