-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protobuf deserialization to consumer and serialization to producer #111
Conversation
67a1674
to
a931132
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job @xakep666 👍
I reviewed your PR and the majority of my comments are just cosmetic changes.
The only needed change to the feature itself, would be adding a caching mechanism for retrieving the protobuf descriptors.
@random-dwi what about linter error (deprecated github.com/golang/protobuf/jsonpb). Is it ok to add exclusion comment or rule for this? |
@xakep666 regarding the linter error, I would prefer not to introduce already deprecated stuff with a PR. |
@random-dwi This is dependency of protoreflect and there is issue about it jhump/protoreflect#463 so simple replacement is not possible |
a931132
to
0e269e9
Compare
0e269e9
to
d9b6fb0
Compare
@xakep666 I just released version 1.24.0 with the feature included 🎉 |
Description
Added protobuf serialization in producer and deserialization in consumer.
To use this user must supply raw
.proto
schemas by using--proto-file
flag and--proto-import-path
flag to resolve dependencies mentioned inimport
sections. User also can supply compiled.protoset
file(s) using--protoset-file
flag.Values for flags above also duplicated in config file.
To enable protobuf serialization or deserialization user must specify
--value-proto-message
flag which contains message type name.Key may be optionally serialized/deserialized by using flag
--key-proto-message
.Fixes #110
Type of change
Documentation
## [Unreleased]
section ofCHANGELOG.md
README.md
was updatedREADME.md