Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facelift #69

Merged
merged 10 commits into from
Sep 28, 2020
Merged

Facelift #69

merged 10 commits into from
Sep 28, 2020

Conversation

imacrayon
Copy link
Contributor

I've updated the look and feel of the site for 2020.

I'm not sure how this site get deployed but I added the front-end assets to .gitignore so that running npm run production will put them where they need to be. Alternatively you could run NPM locally and then deploy the assets pre-built.

@imacrayon
Copy link
Contributor Author

image

@sethetter
Copy link
Member

Screenshots look awesome! Just trying to run it locally to make sure it's all good. I also don't have access to this site's heroku account, so hopefully there's some auto deploy setup, lol.

@sethetter
Copy link
Member

💯! Got it running locally. I'm not sure how this is deployed yet, looks like heroku, but we'll get that sorted.

New design is fantastic, thanks Christian!

@sethetter
Copy link
Member

@jcbwlkr do you have access to this heroku project? Do we need to add npm i && npm run production to the deploy pipeline somewhere?

@jcbwlkr
Copy link
Member

jcbwlkr commented Sep 28, 2020

@sethetter yeah heroku automatically deploys new commits to master. Right now it sees that it's a Go app because of go.mod and just compiles it and created a default Procfile automatically. Honestly I'm not sure what to do to have it run a node precompile step. I'll look but in the meantime I'll add you as a heroku maintainer

@sethetter sethetter merged commit 187354b into devict:master Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants