Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#55 - added customizable number of pull requests #90

Merged
merged 3 commits into from
Oct 9, 2022
Merged

#55 - added customizable number of pull requests #90

merged 3 commits into from
Oct 9, 2022

Conversation

cjprieb
Copy link
Contributor

@cjprieb cjprieb commented Oct 8, 2022

A next step would be to convert some of the fields to computed fields in HacktoberfestConfiguration so that there's only one spot to change instead of 3. But at least it's all in one location now.

sethetter
sethetter approved these changes Oct 9, 2022
View reviewed changes
Copy link
Member

@sethetter sethetter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for consolidating all of that into a config option. Agreed on making some of it computed, but this meets the issue requirements 💯

@sethetter
Copy link
Member

@cjprieb looks like there's a small conflict in profile.js now that #92 has been merged

@sethetter sethetter merged commit 5fd35da into devict:master Oct 9, 2022
@sethetter sethetter mentioned this pull request Oct 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethetter sethetter sethetter approved these changes

Assignees
No one assigned
Labels
hacktoberfest-accepted
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjprieb @sethetter