Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #44 Fixed Updated email notification #45

Merged

Conversation

devesh711
Copy link
Contributor

Closes #44

This pull request includes a significant update to the email notification template in the CreateJob function, enhancing the user experience by providing a more polished and visually appealing HTML email.

Improvements to email notifications:

  • pkg/server/routes.go: Replaced the plain text email with an HTML template, including styling and structure for better readability and user engagement.

Email Preview

Screenshot 2024-10-06 014037
Screenshot 2024-10-06 013633

@devesh711
Copy link
Contributor Author

@sethetter Can you review this PR.

@sethetter
Copy link
Member

@devesh711 thanks for this! Looks like the TestCreateJob test is failing

@devesh711
Copy link
Contributor Author

@sethetter Oops missed the test file. Updated and tested now.

@sethetter sethetter merged commit 287e6e9 into devict:main Oct 8, 2024
1 check passed
@devesh711 devesh711 deleted the dp/feat/improved-email-notification branch October 13, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Add Position in Email Notification Subject & Body
2 participants