-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Highlighting memory changes in memory editor #306
Open
Eoin-ONeill-Yokai
wants to merge
3
commits into
devinacker:master
Choose a base branch
from
Eoin-ONeill-Yokai:highlighting
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Highlighting memory changes in memory editor #306
Eoin-ONeill-Yokai
wants to merge
3
commits into
devinacker:master
from
Eoin-ONeill-Yokai:highlighting
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks great, nice work! I'll take some time to look it over more soon. |
devinacker
reviewed
Nov 3, 2021
Memory will highlight as it changes and fade out over 1 second. This feature can be enabled or disabled on the right-hand side panel.
Originally was going to parse two-char width in order to speed up iteration, but optimization was premature and wasn't any more performant.
Eoin-ONeill-Yokai
force-pushed
the
highlighting
branch
from
January 5, 2022 08:48
05e2278
to
1917081
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made issue #304 which talked about trying to add something akin to Mesen's data change and access highlighting for the ram viewer. I made this addition last weekend as a kind of proof of concept. It starts disabled, but can be enabled on the right-hand panel.
This MR adds a basic value highlighting feature that illustrates changes in values when stepping through frames. Note that this only highlights actual changes in values, and doesn't highlight execution or reads. It would be a nice long term goal to have this work with arbitrary read/write/execute tracking, but this feels like a nice step toward that and could be extended to cover that in a later date.
The highlight color should respect system themes. Right now it uses the systems "link" color. It would also be nice for the other colors to respect system color schemes and provide a legend on the right-hand side for what each color means (since there's plenty of room to provide that info.)
Anyway, here's a kinda-low-quality gif of the feature in action. Should be enough fps to get the gist of what it's
doing, though I'm quite happy with the fade effect!
There's also a commit for ignoring QT project files in the
.gitignore
entry -- which would be nice to have to prevent accidental IDE project files from being added to the repository.Thanks!