Log more config errors

devinit · Apr 2, 2024 · 439ec01 · 439ec01
1 parent 151eae2
commit 439ec01
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 5 deletions.
diff --git a/assets/core.js b/assets/core.js
diff --git a/src/core/charts/Charts.js b/src/core/charts/Charts.js
@@ -14,7 +14,7 @@ const validConfigs = (config) => {
     window.console.error(
       !config.series
         ? 'Invalid chart config: Series is required!'
-        : 'Invalid chart config: Invalid series config - expected an array!',
+        : 'Invalid chart config: Invalid series config - expected an array!'
     );
 
     return false;
@@ -44,6 +44,18 @@ const validConfigs = (config) => {
     return false;
   }
 
+  if (config.dataID && !config.baseAPIUrl) {
+    window.console.error('Invalid chart config: baseAPIUrl is required!');
+
+    return false;
+  }
+
+  if (!(config.data || config.url || config.dataID)) {
+    window.console.error('Invalid chart config: one of data/url/dataID is required!');
+
+    return false;
+  }
+
   if (!config.mapping.subCounty) {
     window.console.warn('Potentially invalid chart config: mapping.subCounty may be required!');
 
@@ -82,8 +94,8 @@ const processConfig = (config, baseAPIUrl) => {
 
           dichart.hideLoading();
         });
-      },
-    },
+      }
+    }
   });
 };
 

diff --git a/src/core/utils/tables.js b/src/core/utils/tables.js
@@ -87,7 +87,19 @@ export const validConfigs = (config) => {
   }
 
   if (!config.mapping.subCounty) {
-    window.console.error('Invalid table config: mapping.subCounty is required!');
+    window.console.warn('Potentially invalid table config: mapping.subCounty may be required!');
+
+    return true;
+  }
+
+  if (config.dataID && !config.baseAPIUrl) {
+    window.console.error('Invalid table config: baseAPIUrl is required!');
+
+    return false;
+  }
+
+  if (!(config.data || config.url || config.dataID)) {
+    window.console.error('Invalid table config: one of data/url/dataID is required!');
 
     return false;
   }