Feature/ Add api data fetching in other components #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wakibi
requested changes
Nov 15, 2023
src/core/KeyFacts.js
Outdated
| @@ -22,8 +22,9 @@ const renderViz = (className) => { | |||
| dichart.showLoading(); | |||
| const { keyFacts, location } = window.DIState.getState; | |||
|
|
|||
| if (keyFacts && keyFacts.url) { | |||
| fetchData(keyFacts.url) | |||
| if (keyFacts && (keyFacts.url || keyFacts.dataID)) { | |||
There was a problem hiding this comment.
Could use optional chaining here? And everywhere else we have keyFacts.dataID?
ThatcherK
force-pushed
the
feature/fetch-data-from-api
branch
from
7613f3c to
1101edb
Compare
ThatcherK
force-pushed
the
feature/fetch-data-from-api
branch
from
1101edb to
5c007f8
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
wakibi
approved these changes
Nov 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extending api data fetching to map indicators and tables.
Allow for setting of school geolocation data url/ ID via the CMS