Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature |Api Base URL Config #215

Merged
merged 10 commits into from
Dec 13, 2023
Merged

Feature |Api Base URL Config #215

merged 10 commits into from
Dec 13, 2023

Conversation

ThatcherK
Copy link
Contributor

@ThatcherK ThatcherK commented Dec 5, 2023 •
edited
Loading

Updating the api data fetch to use a baseUrl config that is added via the CMS

@ThatcherK ThatcherK force-pushed the feature/api-base-url-config branch 2 times, most recently from f6761fc to f49420c Compare December 6, 2023 11:06
@ThatcherK ThatcherK requested a review from wakibi December 6, 2023 11:07
@ThatcherK ThatcherK force-pushed the feature/api-base-url-config branch from f49420c to ada5a03 Compare December 13, 2023 09:32
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ThatcherK ThatcherK merged commit 803ce52 into dev Dec 13, 2023
4 checks passed
@ThatcherK ThatcherK deleted the feature/api-base-url-config branch December 13, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wakibi wakibi wakibi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThatcherK @wakibi