api: fix backward compatibility of Substitution, missing function check #2522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mloubout
commented
Jan 21, 2025
| @@ -307,7 +307,8 @@ def _xreplace(self, subs): | |||
| if self in subs: | |||
| new = subs.pop(self) | |||
| try: | |||
| return new._xreplace(subs) | |||
| new, flag = new._xreplace(subs) | |||
| return new, True | |||
There was a problem hiding this comment.
Note: this was actually incorrectly returning False flag in lots of cases (since subs is then empy here) so new._xreplace(subs) would return new, False
georgebisbas
approved these changes
Jan 21, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2522 +/- ##
=======================================
Coverage 87.31% 87.32%
=======================================
Files 238 238
Lines 45810 45829 +19
Branches 4060 4060
=======================================
+ Hits 40000 40020 +20
+ Misses 5126 5125 -1
Partials 684 684 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix backward compat that was applying weights to all derivative missing the
coeff.functioncheck