[TLV-2025] Hello-World #14888
[TLV-2025] Hello-World #14888
Conversation
✅ Deploy Preview for devopsdays-web ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
[AMS-2025] Add amsterdam.dev as Bronze sponsor
There was a problem hiding this comment.
Please move to new folter assets/events/2025-tel-aviv/organizers/
There was a problem hiding this comment.
Please move to new folter assets/events/2025-tel-aviv/organizers/
There was a problem hiding this comment.
Please move to new folter assets/events/2025-tel-aviv/organizers/
There was a problem hiding this comment.
Please move to new folter assets/events/2025-tel-aviv/organizers/
There was a problem hiding this comment.
Please move to new folter assets/events/2025-tel-aviv/organizers/
There was a problem hiding this comment.
Please move to new folter assets/events/2025-tel-aviv/organizers/
There was a problem hiding this comment.
Please move to new folter assets/events/2025-tel-aviv/organizers/
There was a problem hiding this comment.
Please move to new folter assets/events/2025-tel-aviv/organizers/
There was a problem hiding this comment.
Please convert to a png and move to new folter assets/events/2025-tel-aviv/
There was a problem hiding this comment.
Please rename to logo.png and move to new folter assets/events/2025-tel-aviv/
There was a problem hiding this comment.
Hey @toshywoshy thanks for the review - I'm still working on our first commit, hence I put on the "do-not-merge" label, I will remove, once I think we're ready for the first publish.
I ran the create new event utility twice and not all the folder were created, so I ended creating the last one above manually. I always hate doing that - because I'm afraid of copying over old crap (like I did).
In any case I'll ping you once it's ready to be reviewed and merged. Thanks!
There was a problem hiding this comment.
Yes, I know you have it marked as do-no-merge, however I prefer to give feedback sooner rather than later, this way you can work to prepare your PR and get it ready to merge once you are completly ready.
As for the scripts, we need to maintain those better, I personally do not use them however they should reflect the correct way of creating a new event
[AMS-2025] Add bronze FikaWorks; Essent, gold Exoscale
…gram_2025 [LA-2025] Multiple updates
…har1z/devopsdays-web into devopsdays-tlv-2025-helloworld
|
Hey @toshywoshy >> I think I'm done with my first edits. |
There was a problem hiding this comment.
Rename to logo.png, we do not need the square one (in most cases)
There was a problem hiding this comment.
Not required, please remove
There was a problem hiding this comment.
Not sure what this file is doing here?
There was a problem hiding this comment.
Not sure what this file is doing here?
There was a problem hiding this comment.
Not sure what this file is doing here?
There was a problem hiding this comment.
Not sure what this file is doing here?
There was a problem hiding this comment.
Not sure what this file is doing here?
There was a problem hiding this comment.
Not sure what this file is doing here?
There was a problem hiding this comment.
Not sure what this file is doing here?
There was a problem hiding this comment.
@toshywoshy What do I do with all of these files that I didn't even create? Should I manually remove them?
I'm not sure why this happens to begin with - I obviously didn't touch any of the folders or files except for the ones that are under TLV or the new sponsors I've added (Serverless TLV)
What's the right practice here? I didn't add Fikaworks, or amsterdamdev.yml etc. I pulled and rebased and then all kinds of weirdness happens. Wondering what a good practice is here.
There was a problem hiding this comment.
Yes, I know you have it marked as do-no-merge, however I prefer to give feedback sooner rather than later, this way you can work to prepare your PR and get it ready to merge once you are completly ready.
As for the scripts, we need to maintain those better, I personally do not use them however they should reflect the correct way of creating a new event
Please read and take into consideration the following:
I think this should be enough to just get us added to the site to hold the date.
Thanks!