-
Notifications
You must be signed in to change notification settings - Fork 673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEN-2025 inits denver 2025 event, adds shortcodes for linkedin, twitter, slack, and listserv #14897
Conversation
themightymuppet
commented
Feb 20, 2025
- inits denver 2025 event with cfp, earlybird registration, etc.
- adds new shortcodes for linkedin, twitter, slack, and listserv subscriptions that can be used on the body of any city page.
- reorders global CTA in order of timeline
- replaces "follow" twitter with "contact" - time to promote a healthier platform? :)
- updates city data template to include new social shortcodes
✅ Deploy Preview for devopsdays-web ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
<div class = "col-auto offset-1 offset-md-0 welcome-page-cta"> | ||
<a href="https://twitter.com/{{$e.event_twitter}}" class="btn jssocials-share-link event-cta-button" role="button" aria-pressed="true">Follow</a> | ||
<a href="mailto:{{ $e.organizer_email }}?subject=devopsdays Denver - 2025" class="btn jssocials-share-link event-cta-button" role="button" aria-pressed="true">Contact</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WARNING : You are changing theme files!
This has implications beyond your event, as such you're now adding Denver - 2025
to all events that use the CTA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
woops, thanks! That was a copy pasta error. I can pull the theme changes into a separate PR if that's easier for review. thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go into a seperate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go into a seperate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should go into a seperate PR
<a href="https://linkedin.com/company/{{ $e.event_social_linkedin }}" class="fa-brands social-li fa-linkedin" target="_blank" title="Follow on Linkedin"></a> | ||
{{- else -}} | ||
<a href="https://linkedin.com/company/{{ index .Params 0 }}" class="fa-brands fa-linkedin" target="_blank" title="Follow on Linkedin"></a> | ||
{{- end -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about groups or pages?
I think you should add that option, as not all DoD may have company pages, some may have group pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand what link would be included here, as an email would need to havemailto:
added in the href.
And I suspect the better option is to have shortcodes per mailing list system
data/events/2025/denver/main.yml
Outdated
|
||
registration_closed: "" #set this to true if you need to manually close registration before your registration end date | ||
registration_link: "" # If you have a custom registration link, enter it here. This will control the Registration menu item as well as the "Register" button. | ||
registration_link: "https://tickets.devopsdays.org/devopsdays-denver/2025/" # If you have a custom registration link, enter it here. This will control the Registration menu item as well as the "Register" button. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is better to use the shortcode tix
on the registration page, to avoid going offsite
data/events/2025/denver/main.yml
Outdated
# - name: location | ||
# - name: registration | ||
- name: registration | ||
url: https://tickets.devopsdays.org/devopsdays-denver/2025/ | ||
# - name: program |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, better to have a registration page with a shortcode
data/events/2025/denver/main.yml
Outdated
twitter: "capileigh" | ||
organizer_email: "[email protected]" | ||
twitter: "carlajmurray" | ||
organizer_email: "[email protected]" # Put your organizer email address here | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes require a mail to info @
74fa2ec
to
29ca50f
Compare
@toshywoshy separating this into two PRs: |