Fix: ignore-not-found is not working (#138)

* Update artifactorycleanup.py * Update base.py
devopshq · Mar 28, 2024 · c894410 · c894410
1 parent 7e5ba2a
commit c894410
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/artifactory_cleanup/artifactorycleanup.py b/artifactory_cleanup/artifactorycleanup.py
@@ -58,7 +58,7 @@ def cleanup(self, block_ctx_mgr, test_ctx_mgr) -> Iterator[CleanupSummary]:
                 # Delete artifacts
                 for artifact in artifacts_to_remove:
                     with test_ctx_mgr(get_name_for_ci(artifact)):
-                        policy.delete(artifact, destroy=self.destroy)
+                        policy.delete(artifact, destroy=self.destroy, ignore_not_found=self.ignore_not_found)
 
             # Show summary
             print(f"Deleted artifacts count: {len(artifacts_to_remove)}")

diff --git a/artifactory_cleanup/rules/base.py b/artifactory_cleanup/rules/base.py
@@ -321,5 +321,6 @@ def delete(self, artifact: ArtifactDict, destroy: bool, ignore_not_found: bool =
         except HTTPError as e:
             if e.response.status_code == 404 and ignore_not_found:
                 print(f"NOT FOUND - '{artifact_path}' was not found, so not deleted.")
+                return
             raise