add threads flag to use threads #132
Conversation
|
@allburov this one is for threads |
|
@allburov fixed everything, please let me know if my way of putting the context inside the thread is fine with you |
| @@ -56,9 +59,15 @@ def cleanup(self, block_ctx_mgr, test_ctx_mgr) -> Iterator[CleanupSummary]: | |||
| print(f"Found {len(artifacts_to_remove)} artifacts AFTER filtering") | |||
|
|
|||
| # Delete artifacts | |||
| for artifact in artifacts_to_remove: | |||
| def _delete_with_context(artifact, policy, test_ctx_mgr, get_name_for_ci, destroy, ignore_not_found): | |||
There was a problem hiding this comment.
only artifact argument is required here as I can see, so the signature should be something like
All other methods are imported, flags we can get from self as well.
def _delete(artifact):
with test_ctx_mgr(get_name_for_ci(artifact)):
policy.delete(artifact, destroy=self.destroy)
executor.submit(self._delete, artifact=artifact)Also we could switch to https://docs.python.org/3/library/concurrent.futures.html#concurrent.futures.Executor.map
executor.map(self._delete, artifacts_to_remove)P.S.
Well, it'll create mess in output anyway, because all thread will print in the same output... But it's the useful case for people who doesn't care about CI, agree.
The task is not so easy if we think about that, especially in case where you use it in CI.
|
Multihreading would be awesome for lager repos. looking forward to it :) |
|
Im sorry i was super busy i try to fix the PR on Sunday |
|
@allburov done with your last comment, sorry it took so long :\ |
|
@allburov i did test it with artifactory, im running my clusters retention with 3 workers daily already for a week and its running without issues |
|
@Rommmmm thank you! 👏 |
* add threads flag to use threads and add missing readme for ignore-not-found * add test context manager inside thread * review * review
* add threads flag to use threads and add missing readme for ignore-not-found * add test context manager inside thread * review * review
also add missing readme for ignore-not-found