Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support scala 2.12 #129

Merged
merged 7 commits into from
May 31, 2024
Merged

support scala 2.12 #129

merged 7 commits into from
May 31, 2024

Conversation

WtrLmmrs
Copy link
Contributor

@WtrLmmrs WtrLmmrs commented May 30, 2024 •
edited
Loading

Add support for Scala 2.12

ghostdogpr
ghostdogpr reviewed May 31, 2024
View reviewed changes
Copy link
Collaborator

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a new step in the Github Action config to run tests on 2.12 too?

build.sbt Outdated Show resolved Hide resolved
entities/src/main/scala/com/devsisters/shardcake/Sharding.scala Outdated Show resolved Hide resolved
entities/src/main/scala/com/devsisters/shardcake/internal/ReplyChannel.scala Outdated Show resolved Hide resolved
@ghostdogpr
Copy link
Collaborator

Looks like you need to run Scalafmt as well

@ghostdogpr
Copy link
Collaborator

Not sure if you saw that comment: Can you add a new step in the Github Action config to run tests on 2.12 too? 😄

ghostdogpr
ghostdogpr reviewed May 31, 2024
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
ghostdogpr
ghostdogpr approved these changes May 31, 2024
View reviewed changes
Copy link
Collaborator

@ghostdogpr ghostdogpr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ghostdogpr ghostdogpr merged commit 96ce5a3 into devsisters:series/2.x May 31, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ghostdogpr ghostdogpr ghostdogpr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WtrLmmrs @ghostdogpr