Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document recommendations for root object selection #148

Merged
merged 5 commits into from
Jan 16, 2025

Conversation

dfed
Copy link
Owner

@dfed dfed commented Jan 16, 2025

Addresses #146

@dfed dfed self-assigned this Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.91%. Comparing base (4919abf) to head (a6bdb70).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #148   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          32       32           
  Lines        3467     3467           
=======================================
  Hits         3464     3464           
  Misses          3        3           

@pouyayarandi
Copy link

Great job @dfed
Does it mean that we should store SafeDI.swift file somewhere inside project? We should call Root.init() inside AppDelegate and without storing generated code, Xcode must fail compilation as Root.init() does not exist.
I'd prefer not to store this file because of high probability of code conflict it brings.

@dfed
Copy link
Owner Author

dfed commented Jan 16, 2025

@pouyayarandi if you're using a build plugin the generated tree is in derived data. If you're using a pre-build script and generating the file into your git repo, I would recommend ignoring the file in git

Documentation/Manual.md Outdated Show resolved Hide resolved
@dfed dfed marked this pull request as ready for review January 16, 2025 21:24
@dfed dfed merged commit 9f91eb3 into main Jan 16, 2025
18 checks passed
@dfed dfed deleted the dfed--document-root-146 branch January 16, 2025 22:20
@dfed dfed linked an issue Jan 16, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document how to adopt SafeDI in UIKit / AppDelegate apps
2 participants