Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spec: allow import to merge service definitions #504

Merged
merged 5 commits into from
Dec 15, 2023
Merged

Conversation

chenyan-dfinity
Copy link
Contributor

@chenyan-dfinity chenyan-dfinity commented Dec 13, 2023

There is a unspecified behavior when import contains a main service. This PR supports merging the imported main service via import_service.

Better keyword suggestions are welcome.

Related discussion #431

@chenyan-dfinity
Copy link
Contributor Author

cc @rossberg

spec/Candid.md Outdated Show resolved Hide resolved
spec/Candid.md Outdated Show resolved Hide resolved
@chenyan-dfinity chenyan-dfinity mentioned this pull request Dec 15, 2023
Copy link
Contributor

@crusso crusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spec/Candid.md Outdated Show resolved Hide resolved
@chenyan-dfinity chenyan-dfinity merged commit 491969f into master Dec 15, 2023
4 checks passed
@chenyan-dfinity chenyan-dfinity deleted the import-spec branch December 15, 2023 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants