Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Start a minimal CNS implementation. #66

Merged
merged 4 commits into from
Nov 29, 2024
Merged

feat: Start a minimal CNS implementation. #66

merged 4 commits into from
Nov 29, 2024

Conversation

przydatek
Copy link
Contributor

Start an implementation of a minimal CNS. This PR adds a very minimal CNS root canister with basic tests.

@przydatek przydatek changed the title Start a minimal CNS implementation. feat: Start a minimal CNS implementation. Nov 27, 2024
@przydatek przydatek marked this pull request as ready for review November 27, 2024 11:42
@przydatek przydatek requested a review from a team as a code owner November 27, 2024 11:42
nathanosdev
nathanosdev previously approved these changes Nov 27, 2024
View reviewed changes
dfx.json Show resolved Hide resolved
dfx.json Outdated Show resolved Hide resolved
minimal_cns/README.md Show resolved Hide resolved
minimal_cns/src/backend/cns_root.mo Outdated Show resolved Hide resolved
minimal_cns/src/backend/cns_root.test.mo Show resolved Hide resolved
przydatek
przydatek commented Nov 27, 2024
View reviewed changes
Copy link
Contributor Author

@przydatek przydatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

minimal_cns/README.md Show resolved Hide resolved
minimal_cns/src/backend/cns_root.test.mo Show resolved Hide resolved
minimal_cns/src/backend/cns_root.mo Outdated Show resolved Hide resolved
dfx.json Outdated Show resolved Hide resolved
nathanosdev
nathanosdev previously approved these changes Nov 28, 2024
View reviewed changes
keplervital
keplervital requested changes Nov 29, 2024
View reviewed changes
minimal_cns/src/backend/cns_root.mo Outdated Show resolved Hide resolved
minimal_cns/src/backend/cns_root.test.mo Outdated Show resolved Hide resolved
przydatek
przydatek commented Nov 29, 2024
View reviewed changes
Copy link
Contributor Author

@przydatek przydatek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, PTAL.

minimal_cns/src/backend/cns_root.test.mo Outdated Show resolved Hide resolved
minimal_cns/src/backend/cns_root.mo Outdated Show resolved Hide resolved
@przydatek
Copy link
Contributor Author

Thanks, PTAL.

@przydatek przydatek merged commit 20efb14 into main Nov 29, 2024
6 checks passed
@przydatek przydatek deleted the bartosz/minimal_cns branch November 29, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keplervital keplervital keplervital approved these changes

@nathanosdev nathanosdev nathanosdev left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@przydatek @nathanosdev @keplervital