feat: start a Rust library for querying CNS #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanosdev
reviewed
Feb 4, 2025
| test_client: Principal, | ||
| } | ||
|
|
||
| fn cns_setup() -> CnsSetup { |
There was a problem hiding this comment.
Very minor nit, but why not make this an init function on the CnsSetup struct? Also, maybe it could be called CnsFixture, which I think slightly describes the intention better.
Loosen the requirements on dependencies' versions. Co-authored-by: Nathan Mc Grath <[email protected]>
przydatek
commented
Feb 4, 2025
canisters/test-client/Cargo.toml
Outdated
| include = ["src", "Cargo.toml"] | ||
| homepage = "https://github.com/dfinity/cns#readme" | ||
| repository = "https://github.com/dfinity/cns" | ||
| keywords = [ |
There was a problem hiding this comment.
Oops, not really, copy-paste thing... removed now.
| test_client: Principal, | ||
| } | ||
|
|
||
| fn cns_setup() -> CnsSetup { |
| pic.add_cycles(test_client, INIT_CYCLES); | ||
| println!(" cns_root CID: {}", cns_root); | ||
| println!(" tld_operator CID: {}", tld_operator); | ||
| println!(" test_client CID: {}", test_client); |
There was a problem hiding this comment.
Yes, intentional -- they don't cost much, and are useful when looking at logs of potentially failing tests.
nathanosdev
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a Rust
cns_client-library, for using CNS from Rust, and add the corresponding tests.Also, update the existing CNS canisters to require a dot after the TLD (to comply with the spec).