feat: support application subnets for PocketIC

extensions/nns/CHANGELOG.md

@@ -2,6 +2,7 @@
 
 ## [Unreleased] - ReleaseDate
 - Fixed a bug where `dfx nns install` and `dfx nns import` would fail if a canister type in dfx.json was defined by an extension.
+- Added support for application subnets for `dfx start --pocketic`.
 
 ## [0.4.7] - 2024-11-08
 - Added support for `dfx start --pocketic`.

extensions/nns/e2e/assets/subnet_type/shared_network_settings/application/networks.json

@@ -0,0 +1,7 @@
+{
+    "local": {
+        "replica": {
+            "subnet_type": "application"
+        }
+    }
+}

extensions/nns/e2e/tests/nns.bash

@@ -91,6 +91,22 @@ assert_nns_canister_id_matches() {
     #assert_nns_canister_id_matches nns-dapp
 }
 
+@test "dfx nns install on application subnet" {
+    echo Setting up...
+    install_shared_asset subnet_type/shared_network_settings/application
+    dfx_start_for_nns_install
+
+    run dfx nns install
+
+    if [[ "$USE_POCKET_IC" ]]
+    then
+      assert_success
+    else
+      assert_failure
+      assert_output --partial "The replica subnet_type needs to be 'system' to run NNS canisters."
+    fi
+}
+
 @test "dfx nns install runs" {
 
     echo Setting up...

extensions/nns/src/install_nns.rs

@@ -89,7 +89,19 @@ pub async fn install_nns(
     logger: &Logger,
 ) -> anyhow::Result<()> {
     eprintln!("Checking out the environment...");
-    verify_local_replica_type_is_system(network, networks_config)?;
+    // check if we're talking to PocketIC defaulting to false if we aren't sure
+    let is_pocketic = if let Some(descriptor) = &network.local_server_descriptor {
+        // PocketIC server has `/_/topology` endpoint while the replica does not
+        let endpoint = format!("http://{}/_/topology", descriptor.bind_address);
+        let status = reqwest::get(endpoint).await?.status();
+        status.is_success()
+    } else {
+        false
+    };
+    // PocketIC has multiple subnets and thus supports default application subnet type.
+    if !is_pocketic {
+        verify_local_replica_type_is_system(network, networks_config)?;
+    }
     verify_nns_canister_ids_are_available(agent).await?;
     let provider_url = get_and_check_provider(network)?;
     let nns_url = provider_url.clone();

extensions/sns/src/main.rs

@@ -14,9 +14,9 @@ use crate::commands::{download::SnsDownloadOpts, import::SnsImportOpts};
 use clap::Parser;
 use ic_sns_cli::{
     add_sns_wasm_for_tests, deploy_testflight,
+    health::{self, HealthArgs},
     init_config_file::{self, InitConfigFileArgs},
     list::{self, ListArgs},
-    health::{self, HealthArgs},
     neuron_id_to_candid_subaccount::{self, NeuronIdToCandidSubaccountArgs},
     prepare_canisters::{self, PrepareCanistersArgs},
     propose::{self, ProposeArgs},