feat(ICRC_Ledger): FI-1558: Set 10Tcycles default value for cycles for archive creation #3653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbjorkqvist
commented
Feb 4, 2025
Comment on lines
+15
to
+17
| /// 10 trillion cycles. | ||
| pub const DEFAULT_CYCLES_FOR_ARCHIVE_CREATION: u64 = 10_000_000_000_000; | ||
|
|
There was a problem hiding this comment.
This is the same value currently set for SNS ledgers.
| } | ||
|
|
||
| pub fn test_cycles_for_archive_creation_default_spawns_archive<T>( | ||
| ledger_wasm_current_lowinstructionlimits: Vec<u8>, |
There was a problem hiding this comment.
I think this is just a regular wasm?
maciejdfinity
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the default value for
cycles_for_archive_creationto 10Tcycles.