Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Timer doc comments #685

Merged
merged 5 commits into from
Jan 28, 2025
Merged

Update Timer doc comments #685

merged 5 commits into from
Jan 28, 2025

Conversation

rvanasa
Copy link
Contributor

@rvanasa rvanasa commented Jan 23, 2025

Adjusts the wording of the Timer documentation based on feedback. This is intended as a starting point; please feel free to suggest additional changes.

@rvanasa rvanasa requested a review from a team as a code owner January 23, 2025 22:21
src/Timer.mo Outdated Show resolved Hide resolved
src/Timer.mo Outdated Show resolved Hide resolved
jessiemongeon1
jessiemongeon1 previously approved these changes Jan 23, 2025
src/Timer.mo Outdated Show resolved Hide resolved
src/Timer.mo Outdated Show resolved Hide resolved
Co-authored-by: Jessie Mongeon <[email protected]>
src/Timer.mo Outdated Show resolved Hide resolved
ggreif
ggreif previously approved these changes Jan 24, 2025
Copy link
Contributor

@ggreif ggreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the rewrite. LGTM, but I'm suggesting to add another clause as a result of some recent Slack discussion.

Co-authored-by: Gabor Greif <[email protected]>
@rvanasa rvanasa merged commit 54ac7ee into master Jan 28, 2025
6 checks passed
@rvanasa rvanasa deleted the ryan/timer-docs branch January 28, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants