Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Preparation: Precise Tagging + Graph-Copy-Based Stabilization #4396

Closed
wants to merge 142 commits into from
Closed

Merge Preparation: Precise Tagging + Graph-Copy-Based Stabilization #4396

wants to merge 142 commits into from

Conversation

luc-blaeser
Copy link
Contributor

Preparing merging #4369 in #4286.

Includes an explicit translation of the tagging scheme between the 32-bit runtime system and the 64-bit long-term stable format.

crusso added 30 commits July 4, 2023 13:02
@crusso
tag small words
50a6851
@crusso
progress
fef40ab
@crusso
fix power
ea7d8e3
@crusso
wip
6ea5854
@crusso
fix negatin and signed div
78d4393
@crusso
got numeric-ops passing; beware of shared_code!
c4f0544
@crusso
fix to pass word-rotatios.mo
9c85903
@crusso
fixes to pass words.mo
5e544a2
@crusso
temporarilly accept broken filecheck tests
fbd89a6
@crusso
logical operators, failures exposed my base
4057f2c
@crusso
fix regression in wadd
d126154
@crusso
Update test/run/words.mo
80da73f
@crusso
unshare exotics (could use refactoring)
9fa002f
@crusso
Merge branch 'claudio/small-tags' of github.com:dfinity/motoko into c…
0404c4e 
…laudio/small-tags
@crusso
indent
582bcb2
@crusso
fix wrapped subtraction
a926367
@crusso
fix WMulOp
8e73c4b
@crusso
restore clz32 (deleted by mistake)
41782a8
@crusso
fix candid serialization
77e802e
@crusso
update filecheck output
3436b16
@crusso
disable filechecks (for now)
4a7a3b7
@crusso
really disable filecheck
8e4fd1b
@crusso
update test output
907f87b
@crusso
Merge branch 'master' into claudio/small-tags
8e2d264
@crusso
merge with master
669eb56
@crusso
update new conversions to handle small tags
5e10e89
@crusso
update bench numbers
e7ed2ed
@crusso
tagging bug fixes
27dd0bf
@crusso
Merge branch 'master' into claudio/small-tags
21f40b7
@crusso
Merge branch 'master' into claudio/small-tags
dd75dbd
crusso and others added 23 commits February 8, 2024 12:42
@crusso
Update test/bench/alloc.mo
581ab6a
@crusso
improve doc on BitTagged, revealing how complicated this is
cb66eb6
@crusso
simplify tag_const, add comment on 21 bit ok for utf8
1c4941e
@crusso
refactor if_can_tag_i64 to matcn if_can_tag_i32
a65b0c8
@crusso
typos, comments and minor refactorings)
2619d5e
@crusso
refactor
abdc7b0
@crusso
tweak adjust to require equal types for Const32/UnboxedWord32
8a2c7e6
@crusso
fix regression in Nat16, Nat32 conversion
6371b4f
@crusso
Merge branch 'master' into claudio/small-tags-final-untagged-widened
9411889
@crusso @ggreif
experiment: simplify array iter optimization, don't cheat the type sy…
af94af3 
…stem (#4375)

* simplify array iter optimization; make it safe

* fix comparison and comment

* TaggingScheme.debug = false; refactor

* rewrite array iter optimization to to respect compact bignum ranges

* revert TaggingScheme.debug to false

* comments

* optimized EqArrayOffset

* tweaks

* document max array size better

* typo

* Update src/ir_def/ir.ml

Co-authored-by: Gabor Greif <[email protected]>

* Update src/lowering/desugar.ml

---------

Co-authored-by: Gabor Greif <[email protected]>
@crusso
update perf numbers
23c8c88
@crusso
added asserts in adjust stackrep
6f1d1cf
@crusso
cleanup up interface to bigint.rs to avoid use of intermediate 31-bit…
d8890cb 
… scalars
@crusso
reduce heap assertion in idl.mo (previous commit fixed a nat deserial…
4accd8e 
…ization bug)
@crusso
lower heapDifference bound in idl-ops.mo
3c94a3f
@crusso
revert most changes to test stable-regions-are-isolated.mo
53b0d98
@crusso
refact btst64, btstIn64
3be3ea9
@luc-blaeser
Merge branch 'claudio/small-tags-final-untagged-widened' into luc/gra…
9d427a2 
…ph-copy-tagging
@luc-blaeser
Eliminate compiler warning for RTS test
adb0af6
@luc-blaeser
Value tagging in stable format
d9c1656
@luc-blaeser
Adjust RTS unit tests for tagging
b667d88
@luc-blaeser
Fix signed tagged values
b34ebc0
@luc-blaeser
Add RTS unit test for stable value tagging
773ad82
@luc-blaeser luc-blaeser self-assigned this Feb 14, 2024
@luc-blaeser luc-blaeser changed the base branch from master to luc/graph-copy February 14, 2024 14:32
@github-actions GitHub Actions
Copy link

Comparing from 759747f to f61743e:
In terms of gas, 4 tests regressed and the mean change is +6.9%.
In terms of size, 5 tests regressed and the mean change is +0.9%.

@luc-blaeser
Copy link
Contributor Author

Currently not needed for #4225 because the stable data format uses the same tags as the 64-bit main memory representation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@luc-blaeser luc-blaeser

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@luc-blaeser @crusso