Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

++ #4570

Closed
wants to merge 13 commits into from
Closed

++ #4570

wants to merge 13 commits into from

Conversation

bitdivine
Copy link
Member

@bitdivine bitdivine commented Feb 28, 2024

Motivation

Changes

  • Update the way artefacts are merged
    • Note: upload-artifact@v4 has a breaking change that forces this.
  • Update the list of mac builders
    • Disabled macos-11 because docker fails to start on macos-11. Presumably the OS is too old and teh docker integration is no longer maintained correctly.
    • Kept macos-12
    • Added macos-13 and macos-14
  • Run the hash comparison test regardless of how many builds succeeded.
    • Note: The overall workflow will still fail if one build fails, but there will be more information available from the run. E.g. a workflow run could be summarized as: "3 of 4 builds succeeded, those 3 hashes are the same. But the workflow fails on account of that one failed build."

Tests

Todos

  • Add entry to changelog (if necessary).

@bitdivine
Copy link
Member Author

Closing in favour of #4574

@bitdivine bitdivine closed this Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant