Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: The reproducible workflow is no longer messed up because of breaking changes in the upload-artifacts step #4575

Merged
merged 6 commits into from
Feb 29, 2024

Conversation

bitdivine
Copy link
Member

@bitdivine bitdivine commented Feb 29, 2024

Motivation

uplaod-artifact@v4 contains a breaking change in the way artifacts are merged. The release notes describe how to merge with v4.

Changes

  • Update the way artefacts are merged
    • Note: upload-artifact@v4 has a breaking change that forces this.
  • Disable mac builders
    • Mac builds are broken at the moment; this is being addressed.

Tests

  • See CI. I have added the working branch for this PR as a workflow trigger, so the workflow run can be seen there.

Todos

  • Add entry to changelog (if necessary).

@bitdivine bitdivine marked this pull request as ready for review February 29, 2024 12:06
@daniel-wong-dfinity-org
Copy link
Contributor

Changelog?

@bitdivine bitdivine changed the title fix: merge docker build artifacts fix: The reproducible workflow is no longer messed up because of breaking changes in the upload-artifacts step Feb 29, 2024
@bitdivine bitdivine enabled auto-merge February 29, 2024 15:41
@bitdivine bitdivine added this pull request to the merge queue Feb 29, 2024
Merged via the queue into main with commit 60c5c4b Feb 29, 2024
49 of 50 checks passed
@bitdivine bitdivine deleted the merge-docker-build-artifacts branch February 29, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants